✨ New sniff to verify that spaces are used for mid-line alignment #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDGrimes
approved these changes
May 6, 2017
jrfnl
force-pushed
the
feature/new-use-spaces-for-alignment-sniff
branch
3 times, most recently
from
3f5e584
to
bf5a749
Compare
> Tabs should be used at the beginning of the line for indentation, while spaces can be used mid-line for alignment. This new sniff covers the second part of this rule. (The first part is already covered by the `Generic.WhiteSpace.DisallowSpaceIndent` sniff). The error which is thrown is auto-fixable. The new sniff has been added to the `WordPress-Core` ruleset.
jrfnl
force-pushed
the
feature/new-use-spaces-for-alignment-sniff
branch
from
bf5a749
to
893cd78
Compare
…abs` sniff. Also brings some function group comments inline with an earlier change and/or with the comment from the abstract parent class.
GaryJones
reviewed
May 6, 2017
| * 'lambda' => array( | ||
| * 'type' => 'error' | 'warning', | ||
| * 'message' => 'Use anonymous functions instead please!', | ||
| * 'functions' => array( 'file_get_contents', 'create_function' ), |
There was a problem hiding this comment.
This seems to be an unrelated change?
There was a problem hiding this comment.
See above:
Mostly involved getGroups() function example comments. Some of these have also been adjusted slightly to be in line with an earlier change (#812) in which these were missed and/or with the comment from the abstract parent class.
GaryJones
approved these changes
May 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new sniff covers the second part of this rule. (The first part is already covered by the
Generic.WhiteSpace.DisallowSpaceIndentsniff).The error which is thrown is auto-fixable.
The new sniff has been added to the
WordPress-Coreruleset.Violations against this sniff in the WPCS codebase have been fixed.
Mostly involved
getGroups()function example comments. Some of these have also been adjusted slightly to be in line with an earlier change (#812) in which these were missed and/or with the comment from the abstract parent class.N.B.: I consider this sniff a candidate for pulling upstream to
Genericin due time.N.B.2: This sniff could probably do with some additional unit tests, but I couldn't think of any more, so ideas/code snippets welcome. (The run over the WPCS code base did not yield any incorrect fixes or false positives, so I'm not too worried)